Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Data Source #84

Merged
merged 32 commits into from
Feb 14, 2024
Merged

Live Data Source #84

merged 32 commits into from
Feb 14, 2024

Conversation

APB9785
Copy link
Collaborator

@APB9785 APB9785 commented Oct 20, 2023 •
edited
Loading

Frontend half of #68

Note the tests in here won't pass until BeaconCMS/beacon#363 is merged

Implementation

  • Adds LiveDataEditorLive.Index for CRUDing routes by path
  • Adds LiveDataEditorLive.Assigns for CRUDing assigns of a single route
  • Links use sanitized path and the assigns' key (instead of UUIDs for both). This was particularly helpful in a previous iteration, now it doesn't matter anymore and could be either way with minimal lift

@APB9785 APB9785 self-assigned this Oct 20, 2023
@leandrocp leandrocp mentioned this pull request Nov 2, 2023
Closed
@AZholtkevych AZholtkevych linked an issue Jan 12, 2024 that may be closed by this pull request
General Improvements: Create and modify data source at runtime #68
Closed
@leandrocp leandrocp mentioned this pull request Jan 18, 2024
Merged
APB9785 and others added 14 commits January 22, 2024 13:45
@leandrocp leandrocp marked this pull request as ready for review February 14, 2024 21:20
@leandrocp
Copy link
Contributor

❤️

@leandrocp leandrocp merged commit b7a8e78 into main Feb 14, 2024
3 checks passed
@leandrocp leandrocp deleted the apb/data-source branch February 14, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@APB9785 APB9785

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

General Improvements: Create and modify data source at runtime
3 participants
@APB9785 @leandrocp @alexandrexaviersm